doc: add example for cache factory #19139
Conversation
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
thanks @jizezhang I had a quick look, it does make sense.
Will have a better look later.
Hi @milenkovicm , do you have any thoughts on this PR? Thanks. |
|
apologies @jizezhang it slipped off my radar. |
milenkovicm
changed the title
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
I think this makes sense @jizezhang please just consider adding some documentation
| match self { | ||
| Self::Dataframe => "dataframe", | ||
| Self::DeserializeToStruct => "deserialize_to_struct", | ||
| Self::CacheFactory => "cache_factory", |
There was a problem hiding this comment.
maybe doc should be updated cargo run --example dataframe -- [dataframe|deserialize_to_struct|cache_factory]
| .cache() | ||
| .await?; | ||
|
|
||
| println!("caching has not been executed"); |
There was a problem hiding this comment.
is this print relevant?
Hi @milenkovicm , thanks for reviewing. I added doc and a bit clean up. Please take a look again when you get a chance. Thanks! |
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
i think this makes sense thanks @jizezhang
2 participants
Which issue does this PR close?
CacheFactorywithDataFrame::cache#18893.Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?